-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix cell content imported from .ods files #5703
Conversation
Lets double check, because I made the change because of:
In a800334 A but before there was just no check. |
where? I didn't get it. it just same what I see in LibreOffice. |
jasp-stats/jasp-issues#2789 (comment) As you can see there for me its not the same as in my local libreoffice instance... |
So what should we do now? seems a high impact. |
Im now also checking on linux, as something weird seems to be going all alright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill merge it, because I think the problem with the ODS and characters in there is quite unrelated to this anyway.
Fix: jasp-stats/jasp-issues#2963
Fix: jasp-stats/jasp-issues#2789
I'm not entirely sure about this behavior, but it seems shoud just get depth of
<table:table-cell>
but not concatenating strings<text:p>
unless it's empty?