Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix cell content imported from .ods files #5703

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

shun2wang
Copy link
Contributor

@shun2wang shun2wang commented Oct 15, 2024

Fix: jasp-stats/jasp-issues#2963
Fix: jasp-stats/jasp-issues#2789

<table:table-row table:style-name="ro1">
        <table:table-cell table:style-name="ce1" office:value-type="float" office:value="0.2" calcext:value-type="float">
                 <text:p>0,2</text:p>
        </table:table-cell>
</table:table-row>

I'm not entirely sure about this behavior, but it seems shoud just get depth of <table:table-cell> but not concatenating strings <text:p> unless it's empty?

@shun2wang shun2wang requested a review from JorisGoosen October 15, 2024 15:17
@shun2wang shun2wang changed the title Fix cell content imported from .ods files bugfix: fix cell content imported from .ods files Oct 15, 2024
@JorisGoosen
Copy link
Contributor

JorisGoosen commented Oct 16, 2024

Lets double check, because I made the change because of:

  • If you enter a float in libre-office and export to ods the value would get duplicated and pasted

This is because of some office:float attribute, which gets read, as does the text:p att.
It is solved by just making sure to not past an exact copy of _currentCell on _currentCell

In a800334

A but before there was just no check.
I guess with this behaviour it switches from taking the last text in the cell to taking the first value.
If that one solves all the problems then all the better ^^

@JorisGoosen
Copy link
Contributor

JorisGoosen commented Oct 16, 2024

afbeelding
This seems broken still
afbeelding

@shun2wang
Copy link
Contributor Author

shun2wang commented Oct 16, 2024

This seems broken still.

where? I didn't get it. it just same what I see in LibreOffice.

@JorisGoosen
Copy link
Contributor

JorisGoosen commented Oct 16, 2024

jasp-stats/jasp-issues#2789 (comment)

As you can see there for me its not the same as in my local libreoffice instance...
In fact, JASP seems better at reading it...

@shun2wang
Copy link
Contributor Author

So what should we do now? seems a high impact.

@JorisGoosen
Copy link
Contributor

Im now also checking on linux, as something weird seems to be going all alright.

Copy link
Contributor

@JorisGoosen JorisGoosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill merge it, because I think the problem with the ODS and characters in there is quite unrelated to this anyway.

@JorisGoosen JorisGoosen merged commit 33ef4ea into jasp-stats:development Oct 22, 2024
1 check passed
@shun2wang shun2wang deleted the fixOdsImporting branch October 22, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants