Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release fixes #206

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Release fixes #206

merged 2 commits into from
Nov 30, 2023

Conversation

FBartos
Copy link
Collaborator

@FBartos FBartos commented Nov 29, 2023

fixes: https://github.com/jasp-stats/jasp-test-release/issues/2484
fixes: https://github.com/jasp-stats/jasp-test-release/issues/2492

(also found some old qml names (i.e., lines 1557-1558 and 1712)

@FBartos FBartos requested a review from Kucharssim November 29, 2023 09:21
@FBartos
Copy link
Collaborator Author

FBartos commented Nov 29, 2023

the linux unit tests fails on jaspTools installation...

@FBartos
Copy link
Collaborator Author

FBartos commented Nov 30, 2023

@Kucharssim
Copy link
Member

also fixes: https://github.com/jasp-stats/jasp-test-release/issues/2492

I think you gotta edit the main comment, otherwise the issue won't be linked

Copy link
Member

@Kucharssim Kucharssim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, the issues appear to be fixed

@FBartos FBartos merged commit c8853b2 into jasp-stats:master Nov 30, 2023
5 checks passed
@FBartos FBartos deleted the release-fixes branch November 30, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants