Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference of CVE-2021-3443 to NEWS file #362

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

jubalh
Copy link
Member

@jubalh jubalh commented Oct 30, 2023

No description provided.

@jubalh jubalh requested a review from mdadams November 5, 2023 13:15
@mdadams
Copy link
Collaborator

mdadams commented Nov 5, 2023

Michael, any ideas why the macos builds are failing? This seems rather bizarre. As they work for me, and your changes do not change anything other than a text file, unless my eyes are deceiving me. Also, I am not sure why the Ubuntu 20.04 gcc case is being run at all. I disabled this due to an apparent Ubuntu bug (which i documented in the GitHub Actions workflow file in a recent commit.) Maybe GitHub Actions is using a different version of the workflow file for your PR? These matters aside, I see no problem with your PR.

@jubalh
Copy link
Member Author

jubalh commented Nov 5, 2023

Hm the macos test seems to fail because of some package from homebrew. But on master (where later commits happened) it isn't so I guess it was something temporary. I'll try to trigger a rebuild :)

@mdadams
Copy link
Collaborator

mdadams commented Nov 5, 2023

Triggering a rebuild would be helpful to that I know what I am getting myself into if I merge the PR. Clearly, your change should not break any builds/tests. But it would be helpful to know if the problem was transient or is new (so I know if I will have to spend time fixing a GitHub runner problem if it was not temporary). I have noticed that GitHub does not keep the OS snapshots in its runners fixed, which is quite annoying since they often introduce breaking changes in their runners and then stuff that passed CI tests before suddenly breaks through no fault of our own.

@jubalh
Copy link
Member Author

jubalh commented Nov 5, 2023

Looks like macos is building fine now. Not sure what's going on with Ubuntu 20.04 gcc CI.

@mdadams
Copy link
Collaborator

mdadams commented Nov 5, 2023

My assessment of the situation is described in the comment that I added in the following recent commit: da765f5. I think that Ubuntu broke things. So, I am not currently concerned about the 20.04+GCC case failing.

@mdadams mdadams merged commit abf85ca into jasper-software:master Nov 5, 2023
8 of 9 checks passed
@jubalh jubalh deleted the cve branch November 5, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants