test: run_test_3: drop use of which
#369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`which` is non-portable (not part of POSIX) and distributions like Debian and Gentoo are looking to remove it from their base set of packages. Switch to `type -P` instead given `test/bin/run_test_3` already has a Bash shebang. Signed-off-by: Sam James <[email protected]>
jubalh
approved these changes
Jan 14, 2024
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jan 14, 2024
Some test fixes I noticed when looking at bug #907259 and bug #922074. * Patch out `which` usage (jasper-software/jasper#369). * Depend on openjpeg for tests for the opj2_compress and opj2_decompress binaries. Bug: https://bugs.gentoo.org/907259 Bug: https://bugs.gentoo.org/922074 Closes: #34794 Signed-off-by: Sam James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whichis non-portable (not part of POSIX) and distributions like Debian and Gentoo are looking to remove it from their base set of packages.Switch to
type -Pinstead giventest/bin/run_test_3already has a Bash shebang.