Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game #3

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open

Game #3

wants to merge 69 commits into from

Conversation

HustonMmmavr
Copy link
Contributor

No description provided.

@KSolovyev KSolovyev self-requested a review May 3, 2018 15:15
@KSolovyev KSolovyev self-assigned this May 3, 2018
Copy link
Member

@KSolovyev KSolovyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

на 3 рк договорились сделать поле, по которому бегают колобки. Пока без цветов


public void move() {
if (currentDirection == Direction.RIGHT) {
currentPosition.setX(currentPosition.getX() + velocity);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

договорились перемещать с использованием времени тика клиента

@KSolovyev
Copy link
Member

добавьте ссылку на фронт в описание пр, пожалуйста

<relativePath/> <!-- lookup parent from repository -->
</parent>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>9</java.version>
<java.version>10</java.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

с этим могут возникнуть проблемы на heroku и travic CI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ну хоть var заиспользуйте где-нибудь. А то зачем подключали? =(
https://developer.oracle.com/java/jdk-10-local-variable-type-inference

@KSolovyev
Copy link
Member

очень нужно починить CI

@HustonMmmavr
Copy link
Contributor Author

HustonMmmavr commented May 29, 2018

Спасибо большое, а то я долго искал, не мог найти как это сделать. Только issuses находил и никакого решения

Copy link
Member

@KSolovyev KSolovyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

проблему с двойным ходом надо прям очень быстро фиксить

}

for (GameSession session : gameSessionsController.getGameSessions()) {
clientSnapshotService.processSnapshotsFor(session);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

первое место, где двигаются колобки

if (lobby.isPlaying() && !lobby.isFinished()) {
final GameSession gameSession = lobby.getAssociatedSession();

gameSession.runMechanics(frameTime);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

второе место, где двигаются колобки. Одно надо убрать

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Скорее всего вот это, где мы двигаем колобков пропорционально тику механики, что неверно

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Просто раньше в механике колобки двигались по серверному времени и приходили снепшоты только на поворот. Я вот как раз недавно подправил и сейчас движение колобков завязано на снепшотах клиента и вызов механики я удалил.

clientSnapshotService.processSnapshotsFor(session);
}

//gameTaskScheduler.tick();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

если taskScheduler не тикает, значит он не нужен. Надо удалить

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ок

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants