[Security] Bump checkstyle from 8.8 to 8.29

[dependabot-preview]

Bumps checkstyle from 8.8 to 8.29. This update includes security fixes.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Moderate severity vulnerability that affects com.puppycrawl.tools:checkstyle Due to an incomplete fix for CVE-2019-9658, checkstyle was still vulnerable to XML External Entity (XXE) Processing.

Impact

User: Build Maintainers

This vulnerability probably doesn't impact Maven/Gradle users as, in most cases, these builds are processing files that are trusted, or pre-vetted by a pull request reviewer before being run on internal CI infrastructure.

User: Static Analysis as a Service

If you operate a site/service that parses "untrusted" Checkstyle XML configuration files, you are vulnerable to this and should patch.

Note from the discoverer of the original CVE-2019-9658:

While looking at a few companies that run Checkstyle/PMD/ect... as a service I notice that it's a common pattern to run the static code analysis tool inside of a Docker container with the following flags:

--net=none \
--privileged=false \
--cap-drop=ALL

... (truncated)

Affected versions: < 8.29

Sourced from The GitHub Security Advisory Database.

Moderate severity vulnerability that affects com.puppycrawl.tools:checkstyle Checkstyle prior to 8.18 loads external DTDs by default, which can potentially lead to denial of service attacks or the leaking of confidential information.

Affected versions: < 8.18

Release notes

Sourced from checkstyle's releases.

checkstyle-8.29

https://checkstyle.org/releasenotes.html#Release_8.29

checkstyle-8.28

https://checkstyle.org/releasenotes.html#Release_8.28

checkstyle-8.27

https://checkstyle.org/releasenotes.html#Release_8.27

checkstyle-8.26

https://checkstyle.org/releasenotes.html#Release_8.26

checkstyle-8.25

https://checkstyle.org/releasenotes.html#Release_8.25

checkstyle-8.24

https://checkstyle.org/releasenotes.html#Release_8.24

checkstyle-8.23

https://checkstyle.org/releasenotes.html#Release_8.23

checkstyle-8.22

https://checkstyle.org/releasenotes.html#Release_8.22

checkstyle-8.21

https://checkstyle.org/releasenotes.html#Release_8.21

checkstyle-8.20

https://checkstyle.org/releasenotes.html#Release_8.20

checkstyle-8.19

https://checkstyle.org/releasenotes.html#Release_8.19

checkstyle-8.18

https://checkstyle.org/releasenotes.html#Release_8.18

checkstyle-8.17

https://checkstyle.org/releasenotes.html#Release_8.17

checkstyle-8.16

https://checkstyle.org/releasenotes.html#Release_8.16

checkstyle-8.15

https://checkstyle.org/releasenotes.html#Release_8.15

checkstyle-8.14

http://checkstyle.sourceforge.net/releasenotes.html#Release_8.14

checkstyle-8.13

http://checkstyle.sourceforge.net/releasenotes.html#Release_8.13

... (truncated)

Commits

• 8933d03 [maven-release-plugin] prepare release checkstyle-8.29
• bd45909 Issue #7487: refactor code to use DetailAST.hasChildren()
• 317e51f Issue #7487: add method hasChildren() to DetailAST
• 89b4dcd Issue #3238: Java 8 Grammar: annotations on arrays and varargs
• 252cd89 dependency: bump junit-pioneer from 0.5.1 to 0.5.2
• 2ee2615 dependency: bump junit.version from 5.5.2 to 5.6.0
• 4ed7cb8 minor: add space before xml comment end '-->' to ease reading and make links ...
• c46a16d Issue #7468: disable 'external-parameter-entities' feature by default
• dfed794 minor: add missing test case to SuperCloneCheckTest
• 24e7bdf dependency: bump antlr4.version from 4.7.2 to 4.8-1
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Pull request limits (per update run and/or open at any time)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)