Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AsyncResponse.iter_lines() #182

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Fix AsyncResponse.iter_lines() #182

merged 6 commits into from
Nov 22, 2024

Conversation

vrslev
Copy link

@vrslev vrslev commented Nov 21, 2024

Doesn't work now. Causes an exception:TypeError: 'async for' requires an object with __aiter__ method, got coroutine. MRE:

import asyncio

import niquests


async def main() -> None:
    async with niquests.AsyncSession() as session:
        response: niquests.AsyncResponse = session.post(..., stream=True)
        async for line in response.iter_lines():
            print(line)


asyncio.run(main())

Doesn't work now. Causes an exception:`TypeError: 'async for' requires an object with __aiter__ method, got coroutine`
vrslev added a commit to community-of-python/any-llm-client that referenced this pull request Nov 21, 2024
It is quiet raw yet: jawah/niquests#182

This reverts commit d51f5ae.
Copy link
Member

@Ousret Ousret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ousret Ousret merged commit 29c9c98 into jawah:main Nov 22, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants