🐛 fix attempt to send ping frame in our discrete background idle watc…

…her when the connection has just been closed

CHANGES.rst

@@ -1,3 +1,8 @@
+2.11.907 (2024-10-30)
+=====================
+
+- Fixed attempt to send ping frame in our discrete background idle watcher when the connection has just been closed.
+
 2.11.906 (2024-10-26)
 =====================
 

src/urllib3/_async/connectionpool.py

@@ -169,6 +169,9 @@ async def idle_conn_watch_task(
                 return
             try:
                 async for conn in pool.pool.iter_idle():
+                    if conn.is_connected is False:
+                        continue
+
                     now = time.monotonic()
                     last_used = conn.last_used_at
                     idle_delay = now - last_used

src/urllib3/backend/_async/hface.py

@@ -1595,10 +1595,15 @@ async def ping(self) -> None:  # type: ignore[override]
         if self.sock is None or self._protocol is None:
             return
 
+        if self._protocol.has_expired():
+            return
+
         try:
             self._protocol.ping()
         except NotImplementedError:  # http/1 case.
             return
+        except self._protocol.exceptions():
+            return
 
         while True:
             ping_frame = self._protocol.bytes_to_send()

src/urllib3/backend/hface.py

@@ -1652,9 +1652,14 @@ def ping(self) -> None:
         if self.sock is None or self._protocol is None:
             return
 
+        if self._protocol.has_expired():
+            return
+
         try:
             self._protocol.ping()
-        except NotImplementedError:  # http/1 case.
+        except NotImplementedError:
+            return
+        except self._protocol.exceptions():
             return
 
         while True:

src/urllib3/connectionpool.py

@@ -174,6 +174,9 @@ def idle_conn_watch_task(
 
             try:
                 for conn in pool.pool.iter_idle():
+                    if conn.is_connected is False:
+                        continue
+
                     now = time.monotonic()
                     last_used = conn.last_used_at