🐛 Implement proper flow control when sending a body for HTTP/2 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ousret
force-pushed
the
bugfix-flow-control-out
branch
2 times, most recently
from
e131fb1
to
5ec2221
Compare
Ousret
force-pushed
the
bugfix-flow-control-out
branch
from
5ec2221
to
8b2a3eb
Compare
|
We'll issue another PR with test cases to ensure no regression happens. |
Ousret
added a commit
that referenced
this pull request
Sep 12, 2023
2.0.932 (2023-09-12) ==================== Bugfixes -------- - Fixed `assert_hostname` behavior when HTTPSConnection targets HTTP/3 over QUIC (`#8 <https://github.com/jawah/urllib3.future/issues/8>`__) - Fixed protocol violation for HTTP/2 and HTTP/3 where we sent ``Connection: keep-alive`` when it is forbidden. (`#16 <https://github.com/jawah/urllib3.future/issues/16>`__) - Fixed ``unpack_chunk`` workaround function in the ``send`` method when body is multipart/form-data (`#17 <https://github.com/jawah/urllib3.future/issues/17>`__) - Fixed the flow control when sending a body for a HTTP/2 connection. The body will be split into numerous chunks if the size exceed the specified blocksize when not using HTTP/1.1 in order to avoid ProtocolError (flow control) (`#18 <https://github.com/jawah/urllib3.future/issues/18>`__)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.