[JAX/distributed] Small clean ups on warning emissions in jax.distributed. #24853
+25
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkinsp
requested changes
Nov 16, 2024
jax/_src/distributed.py
Outdated
| ) | ||
| ) | ||
| _any_is_none = lambda *args: any(arg is None for arg in args) | ||
| if _any_is_none(coordinator_address, num_processes, process_id, local_device_ids): |
There was a problem hiding this comment.
Perhaps:
if None in (coordinator_address, num_processes, process_id, local_device_ids):
...
might be shorter? No auxiliary function needed.
There was a problem hiding this comment.
Thanks. This is much better. Done.
jax/_src/distributed.py
Outdated
| ``num_processes``, and ``process_id`` arguments to :func:`~jax.distributed.initialize`. | ||
| ``num_processes``, ``process_id``, and ``local_device_ids`` arguments | ||
| to :func:`~jax.distributed.initialize`. When all four arguments are provided, cluster | ||
| envs auto detection will be skipped. |
There was a problem hiding this comment.
Nit: expand the abbreviation.
environment auto detection will be skipped.
yliu120
force-pushed
the
check_proxy_envs
branch
from
3c33434
to
1af1693
Compare
name typo fix. Fixes comments.
yliu120
force-pushed
the
check_proxy_envs
branch
from
1af1693
to
609dfac
Compare
|
Commits squashed and rebase to upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different users have different cluster setups. Some warnings might be meaningful for some users but not all. emitting those warnings regardless of the user's specific cluster env could lead to 1) noisy logging and 2) confusions.
This PR does two tiny things inside
jax._src.distributed:auto_detect_distributed_paramsmethod a bit to make it more readable and update the comments._src.distributedcode, we should explicitly tell readers when all necesary args are provided, the auto-detect thing is skipped. Otherwise, users need to go in and look around to know this. Also update the comment of the method.