[Mosaic] Canonicalize integer tpu::UnpackSubelementsOp
with sign_extended=false
if it's used by pack that reduces the bitwidth.
#32721
+27
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Mosaic] Canonicalize integer
tpu::UnpackSubelementsOp
withsign_extended=false
if it's used by pack that reduces the bitwidth.This happens in retiling (8, 128) <-> (8 * packing, 128) and (1, 128) <-> (packing, 128), where it unpacks x -> 32 and packs 32 -> x.
jax/jaxlib/mosaic/dialect/tpu/transforms/apply_vector_layout.cc
Lines 8362 to 8396 in 44b5082