Relax shape check in _compute_fans.
#32739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_821295055
branch
3 times, most recently
from
ae62b80 to
2d932d6
Compare
The error for a shape of length 1 or less is now only raised when `in_axis` is `-2`. This allows `_compute_fans` to be used with 1D/0D shapes when custom axes are specified. PiperOrigin-RevId: 822616111
copybara-service
bot
force-pushed
the
test_821295055
branch
from
2d932d6 to
5466dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax shape check in
_compute_fans.The error for a shape of length 1 or less is now only raised when
in_axisis-2. This allows_compute_fansto be used with 1D/0D shapes when custom axes are specified.