Skip to content

Relax shape check in _compute_fans. #32739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

Relax shape check in _compute_fans. #32739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions jax/_src/nn/initializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,12 @@ def _compute_fans(shape: Sequence[int],
Axes not in in_axis, out_axis, or batch_axis are assumed to constitute the
"receptive field" of a convolution (kernel spatial dimensions).
"""
if len(shape) <= 1:
raise ValueError(f"Can't compute input and output sizes of a {len(shape)}"
"-dimensional weights tensor. Must be at least 2D.")
if in_axis == -2 and len(shape) <= 1:
raise ValueError(
f"Can't compute input and output sizes of a {len(shape)}-dimensional"
" weights tensor with default in-axis. Must be at least 2D or specify"
" in_axis explicitly."
)

if isinstance(in_axis, int):
in_size = shape[in_axis]
Expand Down
Loading