[$50 BOUNTY] [Go] Make analytics collector Start idempotent - #138
Closed
Saiaaax wants to merge 1 commit into
Closed
Conversation
- Add started atomic.Bool field to Collector struct - Start() now returns error: nil on first call, ErrAlreadyStarted on repeat - Add IsStarted() method to report flush loop state - Reset started flag on Stop() and context cancellation - Add 7 unit tests covering single start, repeated start, stop-after-repeated-start, start-after-stop, context cancel, concurrent start, IsStarted before Start Closes #9
Author
|
Superseded by #142 (rebased on latest main to resolve merge conflicts) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes Collector.Start() idempotent so repeated calls do not create duplicate background workers.
Closes #9
Changes
Checklist
Payout address: 0x5253757322092903C2F0a8EfEed592344216CC7E