[0 BOUNTY] [C] Define logger behavior after shutdown - #143
Open
Saiaaax wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defines post-shutdown behavior for the legacy logger: after
log_shutdown(), alllog_message()calls are silently dropped (no crash), andlog_is_shutdown()reports the state. Re-initialization vialog_init()re-enables logging.Closes #15
Changes
Modified:
frailbox/include/logger.hlog_shutdown()documentation: defined post-shutdown behavior (silent drop, no crash)log_is_shutdown()declaration with documentationModified:
frailbox/src/logger.cg_shutdownstatic flaglog_init()resetsg_shutdown = 0log_message()checksg_shutdownunder mutex: if shutdown, silently returns (drops message)pthread_mutex_lockinlog_message()log_shutdown()setsg_shutdown = 1before closing filelog_is_shutdown()implementation (checks under mutex)Added:
frailbox/tests/test_logger_shutdown.c— 5 tests:Updated:
docs/OPERATIONS.md— Added "Logger Post-Shutdown Behavior" sectionTesting
Build diagnostic:
Checklist
Payout address: 0x5253757322092903C2F0a8EfEed592344216CC7E