Conversation
Core (lib/lasso/): - Health probe batch coordinator: improved coordination logic - Provider pool: rate limit awareness in health tiering, probe-based health reporting - Selection: rate-limited provider tiering in strategy selection - Circuit breaker: remove redundant error handling - Error classification: updated rate limit detection - JSONRPC error: improved error code handling Dashboard (lib/lasso_web/): - Consolidate format helpers into Formatting module (format_latency, format_rps, format_region_name, success_rate_color) - Remove duplicated inline helpers from chain_details_panel and metrics_tab - Refactor provider_details_panel block height resolution into helper functions - Use cluster_block_heights for real-time consensus height in chain details - Make strategy_display_name/strategy_description public in endpoint_helpers - Remove unused get_strategy_description from helpers - Remove unused chain status route and controller action - Metrics tab: filter nil/unknown regions, use Formatting delegates Tests: - New: error_test, provider_pool_probe_health_test, selection_rate_limit_tiering_test - Updated: error_classification_test, circuit_breaker_test, integration tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ename, graceful shutdown Key changes: - Rename round_robin strategy to load_balanced across routes, controllers, UI, and config - Add backward-compatible round-robin route aliases - Add Plug.Cowboy.Drainer for graceful HTTP request draining on shutdown - Fix error handling: probe classification, client_error failover, 4xx reclassification - Fix providers stuck unhealthy: graduated recovery, error exclusion, block range pre-filtering - Update provider adapters (dRPC URL fix, merkle, llamarpc, 1rpc, generic) - Add load_balanced strategy implementation - Add new test coverage for error normalizer, failover strategy, probe classification - Update docs: API reference, architecture, configuration, observability, routing Synced from cloud commits 9f19dfc..2826269. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Validation CheckChecked out this branch and ran basic validation:
This PR is from Feb 10 and predates the larger 50-commit cloud sync (Feb 21). The larger sync likely subsumes most of these changes (error handling, load_balanced rename, provider health improvements). Recommendation: This can be closed — the subsequent cloud sync on @claude — can you review the diff on this PR and confirm whether all changes here are superseded by the Feb 21 sync, or if there are any unique changes that should be cherry-picked? |
|
Claude finished @jaxernst's task in 3m 16s —— View job PR Diff Analysis
FindingsThe Feb 21 sync branch isn't available locally, so this analysis is based on direct inspection of the two commits in this PR ( Short answer: Yes, close this PR. The Feb 21 sync should subsume all of these changes since it covers more commits from the same cloud main lineage. However, there are three areas worth spot-checking in the Feb 21 sync before merging it. Changes in this PR and their supersession statusCommit 1 ( All of these are straightforward cloud-to-OSS syncs with no OSS-specific adaptations:
All superseded by the Feb 21 sync if it covers the same cloud commits. Commit 2 ( The cloud→OSS logic here is largely mechanical, but two areas were manually adapted for OSS and need verification in the Feb 21 sync:
RecommendationClose this PR. The Feb 21 sync subsumes the cloud logic. Before merging that PR, verify:
If any of these were missed in the Feb 21 sync, they're the only items worth cherry-picking. |
…-health-and-dashboard-cleanup
OSS Sync from lasso-cloud
Synced from cloud commits
9f19dfc..2826269(12 commits on cloud main).This PR includes two sync commits:
f5b5a2d— Provider health monitoring + dashboard cleanup (previous sync)60e92dc— Error handling fixes, load_balanced strategy rename, graceful shutdownChanges
Strategy Rename (round_robin → load_balanced)
round_robinstrategy toload_balancedacross routes, controllers, config, and UI/round-robin/route aliases (map torpc_load_balanced)strategy_from/2,parse_strategy/1,default_strategy/0with backward compatEndpointHelpers,SimulatorControls,EndpointSelectorJS hookload_balanced.exstrategy implementationError Handling & Provider Health
error_normalizer.exanderror_classification.eximprovementsInfrastructure
Plug.Cowboy.Drainerfor graceful HTTP request draining on shutdown (SIGTERM during deploys)Docs
docs/ROUTING.md)Tests
probe_classification_test.exs,failover_strategy_test.exs,error_normalizer_test.exsSkipped (cloud-only / diverged)
lib/lasso_cloud/— all proprietary modules (billing, metering, entitlements)lib/lasso_web/live/home_live.ex— pervasivecurrent_accountconditional renderinglib/lasso_web/sockets/rpc_socket.ex— heavily cloud-specific (API key auth, CU metering, rate limiting)config/runtime.exs,config/test.exs— CU quota enforcement config (cloud metering)priv/repo/migrations/— database migrationsdocs/internal/— internal planning docsconfig/profiles/premium.yml— cloud-only tierVerification
--warnings-as-errorsLassoCloud,APIKeyAuthPlug,CUPlug, etc.)mix format🤖 Generated with Claude Code