feat: add multi-tailnet configuration support to tscli #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lee Briggs <[email protected]>
ellipsis-dev
bot
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to aeb5486 in 1 minute and 29 seconds. Click for details.
- Reviewed
644lines of code in10files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. cmd/tscli/config/tailnet/list/cli.go:35
- Draft comment:
For output type 'yaml', consider using a YAML marshaller instead of JSON marshalling to meet the expected output format. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% Without seeing the implementation of output.Print(), we can't be certain if using json.Marshal is problematic. The presence of yaml struct tags and the fact that output.Print takes both the outputType and data suggests it may handle the conversion internally. This could be an intentional design choice to reuse the JSON marshalling logic. I don't have visibility into output.Print() implementation. The current approach might be intentional and working correctly. Without seeing output.Print(), we can't be confident that this is actually a problem that needs fixing. The current implementation might be correct by design. Delete the comment as we don't have strong evidence that using json.Marshal is problematic, and the current implementation might be intentionally handling YAML conversion in output.Print().
Workflow ID: wflow_WXGQhx5877pIjyn8
You can customize 
| tailnets := getTailnets() | ||
| for _, tailnet := range tailnets { | ||
| if tailnet.Name == activeName { | ||
| return &tailnet, nil |
There was a problem hiding this comment.
Avoid taking the address of the loop variable in GetActiveTailnetConfig; use index-based iteration instead.
| var currentTailnet *config.TailnetConfig | ||
| for _, tailnet := range tailnets { | ||
| if tailnet.Name == oldName { | ||
| currentTailnet = &tailnet |
There was a problem hiding this comment.
Avoid taking the address of the loop variable when searching for the existing tailnet; iterate by index to safely get a pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lee Briggs [email protected]
Important
Adds multi-tailnet configuration support to
tscliwith commands to manage tailnets, maintaining backward compatibility with legacy configuration.tscli.cmd/tscli/config/tailnet/cli.goto manage tailnets:add,remove,list,switch, andupdate.main.goto skip API key validation forconfigcommands.client.goto use active tailnet configuration.TailnetConfigandConfigstructs inpkg/config/config.go.pkg/config/config.goto manage tailnets:AddTailnet,RemoveTailnet,SetActiveTailnet,ListTailnets,GetActiveTailnetConfig.configureCLIinmain.goto handle new configuration mode.Newfunction inclient.goto support multi-tailnet configuration.This description was created by
for aeb5486. You can customize this summary. It will automatically update as commits are pushed.