Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid problems on Ubuntu by using a newer version of pip #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dwcramer
Copy link

@dwcramer dwcramer commented May 8, 2017

This role was failing for me on Ubuntu 14.04 due to errors when pip tried to install the cryptography module. Installing pip with easy_install instead of apt-get fixed the problem. Fortunately, there's a reliable role on Galaxy that does that.

@pep8speaks
Copy link

pep8speaks commented May 8, 2017

Hello @dwcramer! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on May 08, 2017 at 20:11 Hours UTC

@dwcramer dwcramer force-pushed the update-apt-cache branch from cecc6bf to d49f69c Compare May 8, 2017 20:02
@jaywink
Copy link
Owner

jaywink commented May 9, 2017

Thanks, wasn't aware of the problem. I use 14.04 as well, but I guess I have pip updated due to actual apps I run their - will need to check this on a clean server. Of course the tricks done in .travis.yml hint towards the problems, not sure why I didn't see it then..

One thing I am wondering, is it really necessary to include a dependency just to pull in pip? Why not do as done previously in the travis config, ie install updated pip via pip itself? This is only a few lines, and avoids depending on another role.

Any reason you wanted to use the dependency role instead of using pip to update pip?

@dwcramer
Copy link
Author

dwcramer commented May 9, 2017

Well, we use tersmitten.pip elsewhere, so it was an easy way for me to fix the problem. It also seemed like a minimal amount of code to add--just add the dependency and galaxy takes care of the rest (i.e. tersmitten.pip is automatically installed when someone uses ansible-galaxy to install your role).

FWIW, that tersmitten guy is a reliable maintainer of this roles. He's always been responsive to PRs and is good about updating his roles to keep up with changes in the OS or whatever.

I'm happy to redo it so I move that stuff from your .travis.yml into the role itself though if you think that's better.

@jaywink
Copy link
Owner

jaywink commented May 12, 2017

@dwcramer I think in this case I would rather avoid the dependency and have pip updated in the role itself. If the role already had dependencies, adding another wouldn't be bad, but I don't really want to introduce the need for dependency roles for something we have a good other way to do in the role with a few lines.

Sorry about this, but if you want to change the PR to do the pip update using this way then that would be awesome and would love to get it merged in 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants