-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid problems on Ubuntu by using a newer version of pip #24
base: master
Are you sure you want to change the base?
Conversation
Hello @dwcramer! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on May 08, 2017 at 20:11 Hours UTC |
Thanks, wasn't aware of the problem. I use 14.04 as well, but I guess I have pip updated due to actual apps I run their - will need to check this on a clean server. Of course the tricks done in One thing I am wondering, is it really necessary to include a dependency just to pull in pip? Why not do as done previously in the travis config, ie install updated pip via pip itself? This is only a few lines, and avoids depending on another role. Any reason you wanted to use the dependency role instead of using pip to update pip? |
Well, we use tersmitten.pip elsewhere, so it was an easy way for me to fix the problem. It also seemed like a minimal amount of code to add--just add the dependency and galaxy takes care of the rest (i.e. tersmitten.pip is automatically installed when someone uses ansible-galaxy to install your role). FWIW, that tersmitten guy is a reliable maintainer of this roles. He's always been responsive to PRs and is good about updating his roles to keep up with changes in the OS or whatever. I'm happy to redo it so I move that stuff from your .travis.yml into the role itself though if you think that's better. |
@dwcramer I think in this case I would rather avoid the dependency and have Sorry about this, but if you want to change the PR to do the pip update using this way then that would be awesome and would love to get it merged in 👍 |
This role was failing for me on Ubuntu 14.04 due to errors when pip tried to install the cryptography module. Installing pip with easy_install instead of apt-get fixed the problem. Fortunately, there's a reliable role on Galaxy that does that.