Skip to content

Conversation

mikemanger
Copy link
Contributor

@mikemanger mikemanger commented Feb 12, 2025

This PR:

  • Drops testing for Django 5.0 (5.0 is EOL in April 2025)
  • Drops support for Python 3.8
  • Tests against Django 5.1, 5.2 alpha and Python 3.13
  • Fixes tests for the dev branch of Django 6.0
  • Updates codebase to use Python 3 syntax for objects, strings and super calls
  • Uses Django 4.2 syntax for setting RequestFactory headers
  • Fixes warnings in GitHub actions
  • Adds pre-commit config for django-upgrade and pyupgrade

@mikemanger mikemanger changed the title Drop Django < 4.2 and Python 3.8 Drop Python 3.8 and fix tests Feb 13, 2025
@mikemanger mikemanger changed the title Drop Python 3.8 and fix tests Drop Python 3.8, update old code and fix tests Feb 13, 2025
Also added the missing Django 5.2 classifier to `setup.py`.
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of dropping support for Django 5.0 before it has actually reached EOL, but since I think it's very unlikely that any changes will be made to that version that we will have to accommodate in the next 2 months, it's fine 👍

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (17fc0b6) to head (79e442b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          400       400           
  Branches        68        54   -14     
=========================================
  Hits           400       400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddabble ddabble changed the title Drop Python 3.8, update old code and fix tests Drop Python 3.8 and Django 5.0, add Python 3.13 and Django 5.10, update old code and fix tests Feb 16, 2025
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Really appreciate that you took the initiative to make these changes, including adding the two very useful pre-commit hooks 😄

@ddabble ddabble merged commit 19edbfa into jazzband:master Feb 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants