Skip to content

Conversation

sutyrin
Copy link

@sutyrin sutyrin commented Jul 10, 2014

Hey,

Thanks for great app.

Caption for Submission.subscriptions says:

If you select none, the system will automatically find the subscribers for you.

I've stumbled upon this non-working and supposedly fixed, it works for me.

Please review, thanks!

@sutyrin
Copy link
Author

sutyrin commented Jul 10, 2014

hmm, I see that introducing custom related_name breaks things. Will repair tests.

@sutyrin
Copy link
Author

sutyrin commented Jul 10, 2014

Ok, wrote another test that seems to cover this case.

Initially, Submission.from_message, that is used extensively in the tests, seems to copy subscriptions from newsletter, which is not exactly replicates the case when submission is created from web with no subscriptions added explicitly.

@sutyrin sutyrin changed the title now sending submission to entire newsletter if subscriptions are empty send submission to entire newsletter if subscriptions are empty Jul 10, 2014
@dokterbob dokterbob changed the title send submission to entire newsletter if subscriptions are empty Send submission to entire newsletter if subscriptions are empty Jan 3, 2016
@w3ichen
Copy link

w3ichen commented Aug 7, 2022

I forked this repo and implemented this pull request for my own purposes.
If anyone is looking to use this fix, feel free to use my fork: https://github.com/MecSimCalc/django-newsletter

@newearthmartin newearthmartin force-pushed the master branch 7 times, most recently from 716b4d8 to e48481c Compare September 7, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants