Blacklists support #115
Open
Blacklists support #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat email address is considered in the Global Blacklist.
For Blacklist, if the name is empty, show an empty string.
Only CSV is supported for now. Format: name, email My Name, [email protected] Your Name, [email protected]
|
Hey @procmail, thanks for the contrib! For me to properly evaluate your work it would be best to look at the dupication of messages separately from the blacklisting (and importing of blacklists). Would be great if you could split out these pull requests. Also, especially for the blacklists, test coverage is a must. Lastly; what would be a use case for the blacklisting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added:
Haven't written any tests yet, will look into it when I can. Haven't tested on Jenkins.