-
-
Notifications
You must be signed in to change notification settings - Fork 303
fix: remove get_preserved_filters and add AdminPreservedFiltersTests #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #741 +/- ##
==========================================
+ Coverage 83.40% 83.98% +0.57%
==========================================
Files 27 27
Lines 1621 1611 -10
Branches 255 253 -2
==========================================
+ Hits 1352 1353 +1
+ Misses 206 196 -10
+ Partials 63 62 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for this @niltonpimentel02! I added a few comments - This issue also relates to #125. I'd like this PR to close that one as well. My initial attempt at reproducing #125 wasn't successful. They're claiming a redirect after a save or update is redirecting from a url that has the derived class model type in it to a url that has the base class model type in it. I couldn't figure out how to navigate the admin pages to trigger that... but I do suspect this might partly be why the |
Hey! I forgot to mention that for my tests here, I installed It would be nice to close both issues, but if we can't reproduce the error from issue 125, it's going to be tricky to resolve, as I managed to reproduce issue 356 here. |
bckohan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @niltonpimentel02! I did verify that this also fixes #125
Context
Additional Comments
If I’m missing anything or overlooking some edge case, please let me know. I'm also open to any ideas or tips regarding the code!
Thanks, everyone 😄
Related Issue
Closes #356
Closes #125