Skip to content

Conversation

@JohananOppongAmoateng
Copy link
Contributor

@JohananOppongAmoateng JohananOppongAmoateng commented Dec 21, 2025

Fix admin bugs: polymorphic inline file uploads and popup validation (#380, #612)

Issues Addressed

  1. Polymorphic inline forms ignoring multipart for FileFields Polymorphic inline form ignoring multipart for FileFields from Django 2.1 #380
  2. Admin add view popup breaks after initial validation error Admin: add view popup breaks if initial submit has validation error #612

Closes #380
Closes #612

@codecov
Copy link

codecov bot commented Dec 21, 2025

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.12%. Comparing base (5b4c237) to head (39ab9ba).

Files with missing lines Patch % Lines
src/polymorphic/admin/helpers.py 81.81% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   83.98%   84.12%   +0.14%     
==========================================
  Files          27       27              
  Lines        1611     1638      +27     
  Branches      253      263      +10     
==========================================
+ Hits         1353     1378      +25     
- Misses        196      197       +1     
- Partials       62       63       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JohananOppongAmoateng JohananOppongAmoateng marked this pull request as ready for review December 22, 2025 00:00
@JohananOppongAmoateng JohananOppongAmoateng self-assigned this Dec 22, 2025
@bckohan bckohan force-pushed the admin-bugs branch 2 times, most recently from 2ed9c7b to 7d1b8af Compare January 6, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin: add view popup breaks if initial submit has validation error Polymorphic inline form ignoring multipart for FileFields from Django 2.1

2 participants