-
-
Notifications
You must be signed in to change notification settings - Fork 303
FormSet Bugs #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JohananOppongAmoateng
wants to merge
9
commits into
jazzband:master
Choose a base branch
from
JohananOppongAmoateng:578
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FormSet Bugs #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 83.98% 84.28% +0.29%
==========================================
Files 27 27
Lines 1611 1654 +43
Branches 253 269 +16
==========================================
+ Hits 1353 1394 +41
Misses 196 196
- Partials 62 64 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e' object has no attribute 'get_real_instance_class'
… polymorphic inline forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple long-standing edge cases in django-polymorphic related to formsets and admin customization. Specifically, it improves how polymorphic formsets handle child form configuration, polymorphic_ctype initialization, and fieldset extensibility in subclassed models.
The changes aim to make polymorphic forms more predictable, composable, and aligned with standard Django behavior, while removing the need for fragile workarounds in downstream projects.
comprehensive documentation about the ManyToMany limitation with polymorphic inline forms to address GitHub issue #294.
Closes #578
closes #549
Closes #472
Closes #363
Closes #294