-
-
Notifications
You must be signed in to change notification settings - Fork 303
feat: Enhance pre-commit hooks to match CI validation #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rodrigobnogueira
wants to merge
1
commit into
jazzband:master
Choose a base branch
from
rodrigobnogueira:enhance-precommit-hooks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,70 @@ | ||
| ci: | ||
| # Don't run these in pre-commit.ci at all | ||
| skip: [lint, format] | ||
| skip: [lint, format, check-lint-strict, check-format-strict, check-package, check-readme, run-tests] | ||
|
|
||
| repos: | ||
| - repo: local | ||
| hooks: | ||
| # Auto-fixing hooks (run first) - runs on changed files only | ||
| - id: lint | ||
| name: Lint | ||
| entry: just lint | ||
| name: Lint (auto-fix) | ||
| entry: bash -c 'uv run ruff check --fix --select I "$@" && uv run ruff check --fix "$@"' -- | ||
| language: system | ||
| pass_filenames: false | ||
| pass_filenames: true | ||
| types: [python] | ||
| stages: [pre-commit] | ||
| verbose: true | ||
|
|
||
| - id: format | ||
| name: Format | ||
| entry: just format | ||
| name: Format (auto-fix) | ||
| entry: uv run ruff format | ||
| language: system | ||
| pass_filenames: true | ||
| types: [python] | ||
| stages: [pre-commit] | ||
| verbose: true | ||
|
|
||
| # Validation hooks - runs on changed files only | ||
| - id: check-lint-strict | ||
| name: Check Lint (CI match) | ||
| entry: bash -c 'uv run ruff check --select I "$@" && uv run ruff check "$@"' -- | ||
| language: system | ||
| pass_filenames: true | ||
| types: [python] | ||
| stages: [pre-commit] | ||
| verbose: true | ||
|
|
||
| - id: check-format-strict | ||
| name: Check Format (CI match) | ||
| entry: uv run ruff format --check | ||
| language: system | ||
| pass_filenames: true | ||
| types: [python] | ||
| stages: [pre-commit] | ||
| verbose: true | ||
|
|
||
| # Global checks (must run on whole project/env) | ||
| - id: check-package | ||
| name: Check Package (CI match) | ||
| entry: uv pip check | ||
| language: system | ||
| pass_filenames: false | ||
| stages: [pre-commit] | ||
| verbose: true | ||
|
|
||
| - id: check-readme | ||
| name: Check README (CI match) | ||
| entry: uv run -m readme_renderer ./README.md -o /tmp/README.html | ||
| language: system | ||
| pass_filenames: false | ||
| stages: [pre-commit] | ||
| verbose: true | ||
|
|
||
| # Optional: Run tests with coverage (manual stage only) | ||
| - id: run-tests | ||
| name: Run Tests with Coverage | ||
| entry: uv run pytest --cov-append | ||
| language: system | ||
| pass_filenames: false | ||
| stages: [manual] | ||
| verbose: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command 'uv pip check' differs from the CI command which uses 'uv run pip check' (via 'just run pip check' in justfile line 62). The pre-commit hook should use 'uv run pip check' to match CI behavior exactly.