fixed the issue where polymorphic_primary_key_name was incorrect for … #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #795 +/- ##
==========================================
+ Coverage 83.34% 83.40% +0.06%
==========================================
Files 27 27
Lines 1615 1621 +6
Branches 256 255 -1
==========================================
+ Hits 1346 1352 +6
Misses 206 206
Partials 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bckohan
force-pushed
the
primary-key-name-regression
branch
2 times, most recently
from
5f0db2d to
f98b07d
Compare
…phic model pk, also issue a deprecration warning for it and remove its internal usage
bckohan
force-pushed
the
primary-key-name-regression
branch
from
f98b07d to
1db064d
Compare
bckohan
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the issue where polymorphic_primary_key_name was incorrect for models with custom primary keys
Closes #758