Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.16.0 release #705

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Prepare 1.16.0 release #705

merged 1 commit into from
Feb 3, 2024

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Feb 3, 2024

No description provided.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ae4ce7) 97.84% compared to head (02a0ff3) 97.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          78       78           
  Lines        3384     3384           
  Branches      384      384           
=======================================
  Hits         3311     3311           
  Misses         42       42           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claudep claudep requested review from dopry and sergei-maertens and removed request for dopry February 3, 2024 17:00
@claudep
Copy link
Contributor Author

claudep commented Feb 3, 2024

@sergei-maertens Do you think we should rather switch to 1.16.0?

@sergei-maertens
Copy link
Contributor

sergei-maertens commented Feb 3, 2024

I think 1.16.0 is more appropriate - the webauthn minimal version bump is a rather big change for the environment of a project using this package. I think it's also good to mention that users can probably uninstall pydantic if no other dependencies or their own project uses it.

With tooling like pip-tools this is managed automatically, but there are plently of people still just freezing their env into a requirements file and they may not need pydantic anymore.

@claudep
Copy link
Contributor Author

claudep commented Feb 3, 2024

but there are plently of people still just freezing their env into a requirements file

/me whistles innocently...

@claudep claudep changed the title Prepare 1.15.6 release Prepare 1.16.0 release Feb 3, 2024
@claudep claudep merged commit 1928748 into jazzband:master Feb 3, 2024
9 checks passed
@claudep claudep deleted the release1156 branch February 3, 2024 19:08
@claudep
Copy link
Contributor Author

claudep commented Feb 3, 2024

Thanks a lot @sergei-maertens for your help today!

@sergei-maertens
Copy link
Contributor

You're welcome! Feel free to ping me if you're in need of reviewa again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants