Skip to content

Prevent XLS precision loss for large integers #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ViceSaber wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

Prevent XLS precision loss for large integers #637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/tablib/formats/_xls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,12 @@ def dset_sheet(cls, dataset, ws):
for i, row in enumerate(_package):
for j, col in enumerate(row):

# Convert large ints to str to avoid XLS float precision loss
# (XLS uses 64-bit floats: precision is limited to ~15 digits)
if isinstance(col, int) and not isinstance(col, bool):
if abs(col) > 9007199254740991: # 2^53 - 1
col = str(col)

# bold headers
if (i == 0) and dataset.headers:
ws.write(i, j, col, bold)
Expand Down
Loading