[Compilation fix] Ensure proper aligned_allocator definition by using vector-aligned#3
Open
hrobeers wants to merge 1 commit intojbaayen:masterfrom
Open
[Compilation fix] Ensure proper aligned_allocator definition by using vector-aligned#3hrobeers wants to merge 1 commit intojbaayen:masterfrom
hrobeers wants to merge 1 commit intojbaayen:masterfrom
Conversation
…ixes compilation with recent eigen releases)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/jbaayen/vortexje/blob/master/vortexje/solver.cpp#L1003 Fails to compile in recent eigen releases due to improper allocator definition.
A simple fix could be replacing:
with:
However, a more readable and less error prone solution is proposed by this pull request with the introduction of vector_aligned: