feat: scripts can now implement integrations #1634
Conversation
|
So the discussion to merge this or not was about the issue that user files are now part of the class path when running the post build and if this could result in problems or not. Right now it only runs with all the dependencies specified by the user code, but not the code itself. (Which is why currently it isn't possible to write integration code within the user code). A possible issue might be that the classloader would hold a lock on the very resources that the integration might try to change, something that especially on Windows might cause problems. |
|
with #1641 this should be doable without "polluting" the integration class path. But it does not yet work because the integration assumes all deps have a GAV... |
Before this change JBang would only look for integrations in the dependencies, now it also looks in the currently compiled code.
quintesse
force-pushed
the
integration_in_script
branch
from
6661ad5 to
7425544
Compare
quintesse
force-pushed
the
integration_in_script
branch
from
7425544 to
cc6cb1a
Compare
|
This is an old PR but I still think it could be useful. The changes are minimal. The only thing is that the new IT tests fail, it seems because the capturing if input and output doesn't work as expected. |
2 participants
Needs #1630 to be applied first