Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get bot username from API #12

Open
bkeepers opened this issue Aug 29, 2017 · 2 comments · May be fixed by #21
Open

Get bot username from API #12

bkeepers opened this issue Aug 29, 2017 · 2 comments · May be fixed by #21

Comments

@bkeepers
Copy link
Contributor

probotUsername is currently hardcoded in defaults.json:

"probotUsername" : "probot-snooze[bot]",

This causes it to not find comments from the app when thawing, which I believe is causing #8.

GET /app will get details from the currently authenticated app. This endpoint isn't supported yet in node-github, but I'll get a PR open for it once octokit/octokit.js#568 is merged. Once it is, I think the app should call this endpoint on startup to get its own name.

@jbjonesjr
Copy link
Owner

wow, that's awesome. a bit buggy that you would always have to use the same probot snooze instance or else this would fail (maybe add instance_id in my magic data section so I can do a quick compare if i don't find anything for fallback?)

This is much cleaner and less string.compare-y. Like it, great suggest!

@jbjonesjr
Copy link
Owner

this is now merged. should this become a part of upstream? robot.user or some sort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants