Use require to load defaults once #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeepers
commented
Aug 31, 2017
There was a problem hiding this comment.
@jbjonesjr I pushed another commit to this branch that moves the defaults from etc/defaults.json to lib/defaults.js. The primary motivation was to allow environment variables to be evaluated in the defaults.
| @@ -0,0 +1,7 @@ | |||
| module.exports = { | |||
| probotUsername: (process.env.APP_NAME || 'probot-snooze') + '[bot]', | |||
There was a problem hiding this comment.
Workaround until #12 is implemented.
There was a problem hiding this comment.
@jbjonesjr oh, I forgot, this was the actual motivation for making this change. The bot name needs to be configurable until #12 is fixed. Would you reconsider this PR for that reason?
|
we talked through this in 🍖 -space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the loading of defaults to be called once using
requireinstead of withJSON.parse(fs.readFileSync(xxx)). It's a little bit cleaner looking, and avoids a synchronous filesystem read on every event.