Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* fix: [venmo] HTML element name change to btnLogin #105

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Zburatorul
Copy link
Collaborator

They changed the login page HTML.

@Zburatorul Zburatorul requested a review from jbms October 1, 2024 04:18
@Zburatorul
Copy link
Collaborator Author

@inderpreet99, can I ask you to verify this works for you?

@vkurup
Copy link

vkurup commented Oct 7, 2024

Not the OP, but I can confirm that this change fixes the Venmo downloader for me:

$ python -m finance_dl.update --config-module finance_dl_config --log-dir logs update venmo
[0/1] venmo [0s elapsed] starting
[0/1] venmo [1s elapsed] 2024-10-06 22:13:04,129 venmo.py:193 [INFO] Initiating log in
[0/1] venmo [3s elapsed] 2024-10-06 22:13:05,926 venmo.py:200 [INFO] Entering username
[0/1] venmo [3s elapsed] 2024-10-06 22:13:06,017 venmo.py:205 [INFO] Skipped
[0/1] venmo [3s elapsed] 2024-10-06 22:13:06,043 venmo.py:207 [INFO] Entering password
[0/1] venmo [8s elapsed] 2024-10-06 22:13:11,263 venmo.py:210 [INFO] Logged in
[0/1] venmo [8s elapsed] 2024-10-06 22:13:11,268 venmo.py:357 [INFO] Fetching history starting from 2024-08-01
[0/1] venmo [8s elapsed] 2024-10-06 22:13:11,268 venmo.py:329 [INFO] Fetching statement: [2024-08-01, 2024-08-31]
[0/1] venmo [11s elapsed] 2024-10-06 22:13:13,851 venmo.py:222 [INFO] Looking for CSV link
[0/1] venmo [11s elapsed] 2024-10-06 22:13:14,004 venmo.py:226 [INFO] Waiting for CSV download
[0/1] venmo [16s elapsed] 2024-10-06 22:13:19,522 venmo.py:228 [INFO] Got CSV download
[0/1] venmo [16s elapsed] 2024-10-06 22:13:19,523 venmo.py:282 [WARNING] Could not parse Bitcoin as date
[0/1] venmo [16s elapsed] 2024-10-06 22:13:19,524 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [16s elapsed] 2024-10-06 22:13:19,524 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [16s elapsed] 2024-10-06 22:13:19,524 venmo.py:282 [WARNING] Could not parse Bitcoin as date
[0/1] venmo [16s elapsed] 2024-10-06 22:13:19,524 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [16s elapsed] 2024-10-06 22:13:19,524 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [21s elapsed] 2024-10-06 22:13:24,566 venmo.py:329 [INFO] Fetching statement: [2024-09-01, 2024-09-30]
[0/1] venmo [23s elapsed] 2024-10-06 22:13:26,274 venmo.py:222 [INFO] Looking for CSV link
[0/1] venmo [23s elapsed] 2024-10-06 22:13:26,350 venmo.py:226 [INFO] Waiting for CSV download
[0/1] venmo [29s elapsed] 2024-10-06 22:13:32,366 venmo.py:228 [INFO] Got CSV download
[0/1] venmo [29s elapsed] 2024-10-06 22:13:32,368 venmo.py:282 [WARNING] Could not parse Bitcoin as date
[0/1] venmo [29s elapsed] 2024-10-06 22:13:32,369 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [29s elapsed] 2024-10-06 22:13:32,369 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [29s elapsed] 2024-10-06 22:13:32,369 venmo.py:282 [WARNING] Could not parse Bitcoin as date
[0/1] venmo [29s elapsed] 2024-10-06 22:13:32,369 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [29s elapsed] 2024-10-06 22:13:32,370 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [34s elapsed] 2024-10-06 22:13:37,435 venmo.py:329 [INFO] Fetching statement: [2024-10-01, 2024-10-06]
[0/1] venmo [36s elapsed] 2024-10-06 22:13:39,236 venmo.py:222 [INFO] Looking for CSV link
[0/1] venmo [36s elapsed] 2024-10-06 22:13:39,370 venmo.py:226 [INFO] Waiting for CSV download
[0/1] venmo [41s elapsed] 2024-10-06 22:13:44,385 venmo.py:228 [INFO] Got CSV download
[0/1] venmo [41s elapsed] 2024-10-06 22:13:44,386 venmo.py:282 [WARNING] Could not parse Bitcoin as date
[0/1] venmo [41s elapsed] 2024-10-06 22:13:44,386 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [41s elapsed] 2024-10-06 22:13:44,386 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [41s elapsed] 2024-10-06 22:13:44,387 venmo.py:282 [WARNING] Could not parse Bitcoin as date
[0/1] venmo [41s elapsed] 2024-10-06 22:13:44,387 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [41s elapsed] 2024-10-06 22:13:44,387 venmo.py:282 [WARNING] Could not parse 0.0 as date
[0/1] venmo [46s elapsed]  --connect=http://localhost:41261 --session-id=9898920f008c4584185098819fb0e55b
[1/1] venmo [46s elapsed] SUCCESS

(Ignore the WARNINGS... they are a separate code change that I introduced to address #72)

@Zburatorul
Copy link
Collaborator Author

Thank you @vkurup.

@Zburatorul Zburatorul merged commit 8df1560 into jbms:master Oct 7, 2024
5 checks passed
@Zburatorul Zburatorul deleted the zbr-20-venmo-btnlogin branch October 7, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants