feat: Remove database dependency and use property values for reading …#182
Merged
jcdcdev merged 1 commit intojcdcdev:dev/v17from Feb 16, 2026
Merged
Conversation
…time storage Replace the custom database table and API layer with native Umbraco property values. Reading times are now calculated via IReadingTimeService and stored directly on content properties. Data migration from the legacy table is handled via a batched HealthCheck instead of a startup migration, giving users feedback and avoiding issues on large sites. - Remove Web API controller, repository, persistence layer, and DTOs - Remove client-side API client, context, repository, and datasource - Add ReadingTimeHealthCheck with batch processing (300 items per run) - Drop legacy database table via migration, delegate data recalculation to HealthCheck - Move TimeSpan conversion to SourceToIntermediate in property value converter Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Owner
|
Hi @Matthew-Wise, this is an awesome refactor! 🚀 I am so pleased you have removed the dependency on the custom db table. I also love the FE simplicity now that the data is stored with the content itself. In principle this PR looks good to go 😄 In the absence of automated testing in the solution I will get this published into an alpha release and test on my blog site. I might write some tests while I'm there. Thank you again for contributing to the project. H5YR 🦄 |
Author
|
All good mate, I do have v16 version I did for the client and we have seen a big drop in SQL usage on staging at least :D Hopefully the testing goes well :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi James,
According to Claude this is only 30% of the files so not that big... :D
Removes the custom database table. Reading times are now calculated by
IReadingTimeService and stored directly on content properties.
Why a HealthCheck instead of a migration?
Doing this in a migration with the need to publish, can cause issues so needed to avoid that.
I have tested it from a new install point of view but I haven't had chance or the data to test the migration sadly.
Oh and seen as this is v17 I removed Nested Content support
Happy to chat over anything either on here on on slack :)
Matt