Change propertyvalueconverter IsValue check for Source prop level to be string based#189
Merged
jcdcdev merged 1 commit intoMar 19, 2026
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Author
|
I've updated the SLN to use the proper csproj file (was still pointing to a |
Owner
|
Thank you for your contribution @MiguelGuedelha! |
Author
|
No worries 😄 A client wants this as part of some improvements to their headless build so was just trying to get it sorted as soon as possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DB stores info as
<span>XXX TIMEUNIT-STRING </span>not as a GUID so the IsValue check will always fail at the moment when checking the value at PropertyLevel => Source, and the Delivery API depends on it to succeed and proceed with its own pipelineFixes #188