Skip to content

Change propertyvalueconverter IsValue check for Source prop level to be string based#189

Merged
jcdcdev merged 1 commit into
jcdcdev:dev/v13from
MiguelGuedelha:bugfix/188-fix-delivery-api-output
Mar 19, 2026
Merged

Change propertyvalueconverter IsValue check for Source prop level to be string based#189
jcdcdev merged 1 commit into
jcdcdev:dev/v13from
MiguelGuedelha:bugfix/188-fix-delivery-api-output

Conversation

@MiguelGuedelha
Copy link
Copy Markdown

@MiguelGuedelha MiguelGuedelha commented Mar 19, 2026

DB stores info as <span>XXX TIMEUNIT-STRING </span> not as a GUID so the IsValue check will always fail at the moment when checking the value at PropertyLevel => Source, and the Delivery API depends on it to succeed and proceed with its own pipeline

Fixes #188

@jcdc-bot
Copy link
Copy Markdown
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@MiguelGuedelha
Copy link
Copy Markdown
Author

I've updated the SLN to use the proper csproj file (was still pointing to a *.10.csproj csproj file instead of *.13.csproj and enabled the delivery API in the test site as well for ease of testing

@jcdcdev
Copy link
Copy Markdown
Owner

jcdcdev commented Mar 19, 2026

Thank you for your contribution @MiguelGuedelha!

@jcdcdev jcdcdev merged commit f8adbc3 into jcdcdev:dev/v13 Mar 19, 2026
2 checks passed
@MiguelGuedelha
Copy link
Copy Markdown
Author

No worries 😄

A client wants this as part of some improvements to their headless build so was just trying to get it sorted as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants