-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the reporting functions #171
Merged
jcrodriguez1989
merged 2 commits into
jcrodriguez1989:develop
from
saxenism:reportingBranch
Jul 14, 2021
Merged
Added the reporting functions #171
jcrodriguez1989
merged 2 commits into
jcrodriguez1989:develop
from
saxenism:reportingBranch
Jul 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrodriguez1989
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Rahul!
jcrodriguez1989
added a commit
that referenced
this pull request
Jul 14, 2021
* Create optimization_ideas.Rmd (#156) Creates optimization_ideas vignette * DCE: examples and Idea section from GCI-2019 DCE: examples and Idea section from GCI-2019 * A PR combining the PRs of all Google Code-in students related to loop-invariate optimizer (#163) thanks! * GCI PR for constant folding optimizer (#164) Co-authored-by: Stephanie <[email protected]> Co-authored-by: Umang Majumder <[email protected]> Co-authored-by: udaydatar7 <[email protected]> Co-authored-by: Eric Liu <[email protected]> Co-authored-by: Pratish <[email protected]> Co-authored-by: Rahul Saxena <[email protected]> * GCI PRs for opt-common-subexpr (#165) thanks! Co-authored-by: Adrian Serapio <[email protected]> Co-authored-by: azamlynny <[email protected]> Co-authored-by: Umang Majumder <[email protected]> Co-authored-by: Jack-horwell <[email protected]> Co-authored-by: Pratish <[email protected]> Co-authored-by: udaydatar7 <[email protected]> Co-authored-by: Juan Cruz Rodriguez <[email protected]> Co-authored-by: Rahul Saxena <[email protected]> * All GCI PRs for constant propagation optimizer (#166) thanks! Co-authored-by: Pratish <[email protected]> Co-authored-by: udaydatar7 <[email protected]> Co-authored-by: Umang Majumder <[email protected]> Co-authored-by: Juan Cruz Rodriguez <[email protected]> Co-authored-by: Rahul Saxena <[email protected]> * All GCI PRs for dead expression optimizer. (#167) thanks! Co-authored-by: Adrian Serapio <[email protected]> Co-authored-by: Umang Majumder <[email protected]> Co-authored-by: Pratish <[email protected]> Co-authored-by: Eric Liu <[email protected]> Co-authored-by: Rahul Saxena <[email protected]> * All GCI PRs for Dead Store Optimizer (#168) thanks! Co-authored-by: Umang Majumder <[email protected]> Co-authored-by: Eric Liu <[email protected]> Co-authored-by: Pratish <[email protected]> Co-authored-by: Adrian Serapio <[email protected]> Co-authored-by: Rishi R <[email protected]> Co-authored-by: Rahul Saxena <[email protected]> Co-authored-by: Juan Cruz Rodriguez <[email protected]> * Conditional Thread Optimizer PR (#162) * Explained Dead Code Elimination * Update opt-dead-code.R * Update opt-dead-code.R * Create opt-dead-code-example.R * Update opt-dead-code.R * Added examples Examples of unoptimized and optimized code to explain dead code elimination * Added #' to example * Non-technical description of dead code elimination * Update to definition in ##Idea GCI user ID Rishi0812 * Added example of Dead Code Elimination * Added Idea Section to Dead Code Elimination Vignette * Updating NEWS.md * Changing \donttest for \dontrun, it seems 4.0.0 will check donttest examples. * Rebuilding site. * Removing renv. * Removing a separate example file for DCE This was introduced when I merged a PR from a student's fork of the `rco`. * Finalizing the Idea section of the DCE * Selected final examples for DCE * Final example selected * Resolved spacing issue * Resolved Spacing Issue - 2 * Resolved Spacing Issue - 3 * Improved the Idea section * Fixed the performance typo * Revert "Fixed the performance typo" This reverts commit c791bef. * Update opt-dead-code.Rmd typo fix * Added a few functions * Added a few functions * Added logic for duplicate expr * Meh * Added merge logic * The entire process of merging implemented. Phhew!! * Ran into the else parse bug * First iteration complete * Final commit for cond_thread * Meh * Resolved duplicate vignette * Solved another issue in vignette build * I'm sleepy now, this is last * Missed a comma :( * I dunno what's happening anymore * Fixed the >= function logic * Last ditch * Ok I'm officially crying now T_T * Now no test would fail * Seriously, this is the last time * Bhak * erfg * Update parse.R * Update opt-constant-folding.R * Update opt-dead-code.R * Dude c'mmon * Update optimize-files.R * Update opt-dead-code.R * plixx * Added more tests to increase coverage * Another test for extra coverage * Implemented suggested changes * Some missing edits * Improved Tests * Fixed boolean condition * Improved indentations * documented * Workaround for R CMD check failed * Version bump & code styling * Examples edit * Fixed the indentation bug * Code Styiling * Provided another example in vignette * Improving vignette * Styling test cases * Fixed unwanted changes due to `;` * Ran all checks, works fine Co-authored-by: Pratish <[email protected]> Co-authored-by: Ian Chang <[email protected]> Co-authored-by: Jack-horwell <[email protected]> Co-authored-by: Rishi R <[email protected]> Co-authored-by: Adrian Serapio <[email protected]> Co-authored-by: Juan Cruz Rodriguez <[email protected]> Co-authored-by: Rahul Saxena <[email protected]> * Adding the Memory Allocation Optimizer (#169) * Initial Commit * Second commit - firm logic in place * First iteration of a working prototype * Just another test text * Tests and Vignettes for mem-alloc opt * Final edits in diff files for the new optimizer * Removed unnecessary files * Reverted changes in man/opt_dead * Reverted changes in man/opt_dead * Reverted changes in man/const_prop * Reverted changes in man/common_subexpr Co-authored-by: Rahul Saxena <[email protected]> Co-authored-by: Juan C Rodriguez <[email protected]> * Possible fix for Issue#107 (#170) * Possible fix for issue#107 * Reverting unrelated changes * Reverting unrelated changes * Reverting unrelated changes Co-authored-by: Rahul Saxena <[email protected]> * Added the reporting functions (#171) * Added the reporting functions * Added comments Co-authored-by: Rahul Saxena <[email protected]> * Please add this doc in the Article section of the official rco website (#172) * Please add this in the Article section of the official rco website * Fixed some blockquote issues * Trying new changes * Delete Document.dcf Co-authored-by: Rahul Saxena <[email protected]> Co-authored-by: Juan C Rodriguez <[email protected]> * Checking merge Co-authored-by: Rahul Saxena <[email protected]> Co-authored-by: Stephanie <[email protected]> Co-authored-by: Umang Majumder <[email protected]> Co-authored-by: udaydatar7 <[email protected]> Co-authored-by: Eric Liu <[email protected]> Co-authored-by: Pratish <[email protected]> Co-authored-by: Rahul Saxena <[email protected]> Co-authored-by: Adrian Serapio <[email protected]> Co-authored-by: azamlynny <[email protected]> Co-authored-by: Jack-horwell <[email protected]> Co-authored-by: Rishi R <[email protected]> Co-authored-by: Ian Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the reporting functions, that can process a folder, set of files, single file and a code snippet to check whether
rco
can perform some optimization on it or not. This is the first iteration for the feature request in the Issue #72.With further research and prompt inputs from users, we will keep on upgrading this reporting function.