Remove cookie

jd-opensource · Jan 27, 2025 · e82b522 · e82b522
1 parent 1b14b9a
commit e82b522
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/...n/java/com/jd/live/agent/plugin/router/springcloud/v3/request/BlockingClusterRequest.java b/...n/java/com/jd/live/agent/plugin/router/springcloud/v3/request/BlockingClusterRequest.java
@@ -23,7 +23,6 @@
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpRequest;
 import org.springframework.http.client.ClientHttpRequestExecution;
-import org.springframework.util.MultiValueMapAdapter;
 
 import java.util.List;
 import java.util.Map;
@@ -91,9 +90,10 @@ public void setHeader(String key, String value) {
 
     @Override
     protected RequestData buildRequestData() {
-        Map<String, List<String>> cookies = getCookies();
-        return new RequestData(request.getMethod(), request.getURI(), request.getHeaders(),
-                cookies == null ? null : new MultiValueMapAdapter<>(cookies), null);
+        // cookie is used only in RequestBasedStickySessionServiceInstanceListSupplier
+        // it's disabled by live interceptor
+        // so we can use null value to improve performance.
+        return new RequestData(request.getMethod(), request.getURI(), request.getHeaders(), null, null);
     }
 
     public byte[] getBody() {

diff --git a/...main/java/com/jd/live/agent/plugin/router/springcloud/v3/request/FeignClusterRequest.java b/...main/java/com/jd/live/agent/plugin/router/springcloud/v3/request/FeignClusterRequest.java
@@ -101,11 +101,12 @@ public void setHeader(String key, String value) {
 
     @Override
     protected RequestData buildRequestData() {
-        Map<String, List<String>> cookies = getCookies();
+        // cookie is used only in RequestBasedStickySessionServiceInstanceListSupplier
+        // it's disabled by live interceptor
+        // so we can use null value to improve performance.
         return new RequestData(
                 org.springframework.http.HttpMethod.resolve(request.httpMethod().name()), getURI(),
-                new HttpHeaders(new MultiValueMapAdapter<>(getHeaders())),
-                cookies == null ? null : new MultiValueMapAdapter<>(cookies), null);
+                new HttpHeaders(new MultiValueMapAdapter<>(getHeaders())), null, null);
     }
 
     public Request.Options getOptions() {

diff --git a/.../java/com/jd/live/agent/plugin/router/springgateway/v3/request/GatewayClusterRequest.java b/.../java/com/jd/live/agent/plugin/router/springgateway/v3/request/GatewayClusterRequest.java
@@ -29,7 +29,6 @@
 import org.springframework.http.HttpCookie;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.server.reactive.ServerHttpRequest;
-import org.springframework.util.MultiValueMapAdapter;
 import org.springframework.web.server.ServerWebExchange;
 import org.springframework.web.util.UriComponentsBuilder;
 
@@ -131,9 +130,10 @@ public boolean isInstanceSensitive() {
 
     @Override
     protected RequestData buildRequestData() {
-        Map<String, List<String>> cookies = getCookies();
-        return new RequestData(request.getMethod(), request.getURI(), request.getHeaders(),
-                cookies == null ? null : new MultiValueMapAdapter<>(cookies), null);
+        // cookie is used only in RequestBasedStickySessionServiceInstanceListSupplier
+        // it's disabled by live interceptor
+        // so we can use null value to improve performance.
+        return new RequestData(request.getMethod(), request.getURI(), request.getHeaders(), null, null);
     }
 
     @Override