Skip to content

bugfix: remove unnecessary image shape check in Qwen2 image processing. #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

bugfix: remove unnecessary image shape check in Qwen2 image processing. #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions xllm/processors/qwen2_vl_image_processor.cpp
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ std::optional<Size> smart_resize(int height,
int factor = 28,
int min_pixels = 56 * 56,
int max_pixels = 14 * 14 * 4 * 1280) {
if (height < factor || width < factor) {
LOG(ERROR) << "Height or width must be larger than factor";
return std::nullopt;
}

if (static_cast<double>(std::max(height, width)) / std::min(height, width) >
200) {
LOG(ERROR) << "Absolute aspect ratio must be smaller than 200";
Expand Down