Skip to content

Conversation

bigbigDreamer
Copy link
Contributor

@bigbigDreamer bigbigDreamer commented Oct 9, 2025

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

Relation Taro TextArea Issue

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能
    • Textarea 组件新增 showCount 属性,可传递字数统计开关至底层组件,支持显示输入字数。
    • 保持原有字数展示的条件渲染不变,无其他行为变化。

@github-actions github-actions bot added action:review This PR needs more reviews (less than 2 approvals) 3.x Target branch 3.x labels Oct 9, 2025
Copy link

coderabbitai bot commented Oct 9, 2025

Walkthrough

在 Taro 版 Textarea 调用处新增 showCount 属性透传至底层 Taro Textarea。现有字符计数的条件渲染保持不变,无控制流调整;对外导出或公共声明未变更。

Changes

Cohort / File(s) Summary
Textarea Taro 适配
src/packages/textarea/textarea.taro.tsx
新增将 showCount 属性透传给 Taro Textarea;既有计数展示的条件渲染保持原样,无额外逻辑改动。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • fix: textarea 鸿蒙适配 #3037 — 同样修改了 src/packages/textarea/textarea.taro.tsx,关注字符计数渲染(将计数容器由 Text 改为 View),与本次透传 showCount 的场景紧密相关。

Suggested reviewers

  • oasis-cloud
  • irisSong
  • xiaoyatong

Poem

我在代码田里蹦三跳,🥕
一根 showCount 悄悄往下飘。
计数没变,风轻巧,
Taro 接住不喧嚣。
耳朵一竖:发布好!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning PR 描述包含了模板的各个标题并对变动类型和自检清单做了勾选,但“相关 Issue”一栏未填写实际链接且将 Issue 链接放在了“需求背景和解决方案”中,同时该部分未说明具体问题所在、最终 API 用法或任何 UI 变更详情,未完全满足模板对问题背景与解决方案的要求。 请将实际的 Issue 链接填写在“相关 Issue”一节中,并在“需求背景和解决方案”中补充问题描述、解决思路、最终 API 用法示例以及必要的 UI 变化或截图说明,以完善模版要求的信息。
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed PR 标题清晰地描述了修复 showCount 属性在支付宝环境中无效的问题,与本次变更的主要内容直接相关,因此符合要求。
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.15%. Comparing base (f1c8cd9) to head (b333131).
⚠️ Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #3366   +/-   ##
==========================================
  Coverage      88.15%   88.15%           
==========================================
  Files            291      291           
  Lines          19212    19212           
  Branches        2988     2988           
==========================================
  Hits           16937    16937           
  Misses          2269     2269           
  Partials           6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiaoyatong xiaoyatong merged commit e9a80b8 into jdf2e:feat_v3.x Oct 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants