-
Notifications
You must be signed in to change notification settings - Fork 284
Fix get bounding react #3368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get bounding react #3368
Changes from all commits
929799b
7ee836a
94c5073
5dfd20f
bd12ee6
e47d0d4
e7a4b1f
75057e6
7da9642
08e97b5
3da0ec6
e90b2b2
3cbfe75
88462db
8ce8c51
68c851b
32b4cea
4e6df5d
cf0553a
1509b39
710afd9
2be0323
2379441
e7f84cc
7054cee
93c518f
1b997a4
23dba7a
0354507
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,6 +55,9 @@ | |
transform: translate(-50%, -50%); | ||
opacity: 0; | ||
content: ' '; | ||
/* #ifdef dynamic*/ | ||
pointer-events: none; | ||
/* #endif */ | ||
Comment on lines
+58
to
+60
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain功能修复合理,但请确认条件宏一致性(dynamic vs harmony dynamic) 此处给 ::before 加 pointer-events: none 能避免覆盖层拦截点击,方向正确。不过本文件前面使用的是 “/* #ifdef harmony dynamic*/”,这里写成了 “/* #ifdef dynamic*/”。若两者在构建预处理并非同义,可能导致某些端未生效,仍出现点击被遮挡的问题。建议统一为同一宏,或两者都兼容一遍以免漏网。 为便捷核查,可在仓库根目录运行下列脚本统计两种写法的分布,评估是否需要统一: 🏁 Script executed: #!/bin/bash
# 检查 SCSS 中 dynamic 条件宏的用法是否一致
echo "Match: /* #ifdef dynamic*/"
rg -n -C1 -g '**/*.scss' $'/\\*\\s*#ifdef\\s+dynamic\\s*\\*/'
echo
echo "Match: /* #ifdef harmony dynamic*/"
rg -n -C1 -g '**/*.scss' $'/\\*\\s*#ifdef\\s+harmony\\s+dynamic\\s*\\*/'
echo
echo "本文件定位:"
rg -n -C2 -g 'src/packages/button/button.scss' $'/\\*\\s*#if(n)?def\\b[^*]*\\*/|pointer-events\\s*:\\s*none\\s*;' Length of output: 8219 🏁 Script executed: #!/bin/bash
echo "Context around ::before in src/packages/button/button.scss"
rg -n -C5 '::before' -g 'src/packages/button/button.scss'
echo
echo "Full file beginning (lines 1–200):"
sed -n '1,200p' src/packages/button/button.scss Length of output: 6348 保持条件宏一致 将 /* #ifdef dynamic*/
pointer-events: none;
/* #endif */ 改为 /* #ifdef harmony dynamic*/
pointer-events: none;
/* #endif */ 确保与文件其他处使用的宏一致,否则该样式在部分构建条件下无法生效。 🤖 Prompt for AI Agents
|
||
} | ||
|
||
&::after { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
pnpm 下 “resolutions” 不生效且版本不一致,建议改为 overrides 并对齐版本
建议修改如下:
说明:
为确认当前仓库实际使用的包管理器与已解析版本,可运行:
Also applies to: 245-246, 239-246
🏁 Script executed:
Length of output: 905
使用 overrides 替换 resolutions 并对齐 @nutui/icons-react-taro 版本
📝 Committable suggestion
🤖 Prompt for AI Agents