Add SQL2003 window function syntax #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Window function declarations were not indented correctly:
```
from
pomm.news window published_at_wdw as (
order by
published_at desc
)
```
Configuring WINDOW as a top level reserved keyword makes the job:
```
from
pomm.news
window
published_at_wdw as (
order by
published_at desc
)
```
|
The fact that you reformat the arrays of keywords/functions make it quite hard to see what is new in them |
|
@stof true, I have made a diff of before and after:
I have tested it in my own project's web debug toolbar and it works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window functions keywords like
WINDOW,OVER,PARTITIONwere not recognized and the SQL formatting was bad when these functions were used.