feat: Lazily evaluated env template variables in path entries #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josb
changed the title
jdx
reviewed
Jun 27, 2024
src/config/env_directive.rs
Outdated
| @@ -79,6 +137,8 @@ impl EnvResults { | |||
| ) -> eyre::Result<Self> { | |||
| let settings = Settings::get(); | |||
| let mut ctx = BASE_CONTEXT.clone(); | |||
| debug!("resolve: input: {:#?}", &input); | |||
There was a problem hiding this comment.
Will fix, I just added these while trying to understand the code. If you feel some serve little purpose I am happy to remove them.
Also, if you have suggestions for better identifier names, I will happily change them. 🙏🏻
There was a problem hiding this comment.
I changed all debug calls to trace, and added a custom deserializer to get both the tests to pass and the lazy path entries to be parsed correctly.
|
Any feedback, @jdx? |
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1912.
Please note that there's a TODO entry in
mise::EnvMapVisitor.visit_map. The issue is thatdeserialize_with = "deserialize_arr"can either be left off or added topath: Vec<PathEntry>:{ value = "{{ env.GEM_HOME }}/bin" }) cause a parse error (invalid type: map, expected a string) but the 3 failing tests now pass.I am hoping you can help me address this issue, as I don't understand Serde / Rust well enough yet.
This is also the reason why I didn't add any tests for this feature yet.
Thanks!