-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLAlchemy 1.4 support #51
Conversation
Anything I can do to help get this merged? This is currently blocking us from upgrading to SQLAlchemy 1.4. |
@dgipps Aside from tagging @jeancochrane and praying, I'm not sure what else to do. 😬 |
Thanks for this @dwreeves @dgipps ! I appreciate the mention, my repo notifications are kind of a mess right now. This seems reasonable to me but it looks like something is up with our pytest configuration. If you want to try to figure it out you're welcome to, otherwise I'll try to dig in later this week. |
08af303
to
7b2041c
Compare
OK my previous commit was extremely lazy. I dug into it a bit more and found out that there is a lot of reliance on deprecated things:
The tests failing to even start is due to this:
So swapping to that works. Here is my run of this workflow, everything passes. Can you approve this workflow? https://github.com/jeancochrane/pytest-flask-sqlalchemy/actions/runs/1054560707 Thanks @jeancochrane! (Edit: Accidentally deleted 1.4.x from main.yml. Added it back in. URL for my workflow references most recent version.) |
Thanks for the review, and thank you for creating and maintaining this project @jeancochrane. This package has been extremely useful for me; glad to contribute to it. |
can we update the documentation as well? |
Thanks for the flag @bbtdev, will update this weekend 👍🏻 |
Fixes issue #50.