Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get reflection working for SA 1.4 #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fgregg
Copy link
Contributor

@fgregg fgregg commented Sep 24, 2021

Working on getting reflection for SA 1.4, will close #55

Also adds an mocked patch for execution_options

This would be cleaner and more specific if it was like

    class EngineMock(mocker.MagicMock):
        pass
    engine = EngineMock(spec=sa.engine.Engine)
    ...
    if version.parse(sa.__version__) >= version.parse('1.4'):
        sa.inspection._registrars[EngineMock] = sa.engine.Inspector._engine_insp

but, somehow subclassing MagicMock like this interferes with the tests from running.

@fgregg
Copy link
Contributor Author

fgregg commented Sep 24, 2021

First need to figure out why tests are not passing. Probably should remove cybergrind's code and isolate what i'm working with.

It was trying to subclass mocker.MagicMock to EngineMock.

@fgregg fgregg changed the title [WIP] Get reflection working for SA 1.4 Get reflection working for SA 1.4 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflection does not work
2 participants