Add PHP syntax check

PreCommitManager.class.php

@@ -91,7 +91,7 @@ public function processChecks(){
       try {
         require_once $this->getCheckDirectory().DIRECTORY_SEPARATOR.$checkName.'Check.class.php';
         $className = $checkName.'Check';
-        $check = new $className($mess);
+        $check = new $className($mess, $this->repoName, $this->trxNum);
         $check->runCheck($fileChanges);
         if ($check->fail()){
           $this->checksWithError[] = $check;

checks/BasePreCommitCheck.class.php

@@ -6,9 +6,13 @@ abstract class BasePreCommitCheck {
   protected $globalError = array();
   protected $codeError = array();
   protected $options = array();
+  protected $repoName = null;
+  protected $trxNum = null;
 
-  public function __construct($svnComment=''){
+  public function __construct($svnComment='', $repoName = null, $trxNum = null){
     $this->svnComment = $svnComment;
+    $this->repoName = $repoName;
+    $this->trxNum = $trxNum;
     $this->parseOptions();
   }
 

checks/SyntaxCheck.class.php

@@ -0,0 +1,55 @@
+<?php
+require_once dirname(__FILE__).DIRECTORY_SEPARATOR.'BasePreCommitCheck.class.php';
+
+class SyntaxCheck extends BasePreCommitCheck 
+{
+  static private $has_php_binary = null;
+
+  public function getTitle()
+  {
+    return "Reject files with syntax error";
+  }
+
+  public function renderErrorSummary()
+  {
+    return "Syntax error found";
+  }
+
+  public function checkFullFile($lines, $filename)
+  {
+    if ( $this->hasOption('no-syntax') ){
+      return;
+    }
+
+    $this->hasPhpBinary();
+
+    if ($this->getExtension($filename) !== 'php') {
+      return;
+    }
+
+    passthru('svnlook cat '.escapeshellarg($this->repoName).' '.escapeshellarg($filename).' -t '.escapeshellarg($this->trxNum).' | php -l', $return);
+
+    if ($return !== 0) {
+      return 'Syntax error in '.$filename;
+    }
+  }
+
+
+  private function hasPhpBinary()
+  {
+    if (self::$has_php_binary === null) {
+      passthru('php --version', $return);
+
+      if ($return !== 0) {
+        throw new Exception('Impossible to find PHP binary');
+      }
+
+      self::$has_php_binary = true;
+    }
+  }
+
+  public function renderInstructions()
+  {
+    return "If you want to force commit with error syntax, add the parameter --no-syntax in your comment";
+  }
+}

pre-commit.tmpl

@@ -8,4 +8,4 @@
 #  * --exculde=XX:ZZZ      To list the checks that must be ignore for that repo
 #
 
-php /{PATH_TO_PHP_SVN_HOOKS_DIR}/svn_pre_commit_hook.php $1 $2 --include=EmptyComment:NoTabs
+php /home/svn/hooks/php-svn-hook/svn_pre_commit_hook.php $1 $2 --include=EmptyComment:Syntax