Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVMe detection #22

Merged
merged 1 commit into from
Aug 29, 2016
Merged

NVMe detection #22

merged 1 commit into from
Aug 29, 2016

Conversation

Shou
Copy link
Contributor

@Shou Shou commented Aug 23, 2016

This should reliably fix the /dev/nvme vs /dev/sda issue #20.

@jeaye
Copy link
Owner

jeaye commented Aug 23, 2016

Thank you for this! What sort of setup do you have which is use /dev/nvme? I'd like to test this locally, before merging, but I'm interested in the use case.

@Shou
Copy link
Contributor Author

Shou commented Aug 23, 2016

I've got a Dell XPS 13 which comes with a nice NVMe SSD drive and I know a few other ultrabooks to do the same, other than customized desktops or servers with NVMe drives that is.

The format should be the NVMe character device /dev/nvme0 followed by the namespace block device /dev/nvme0n1 and finally the partition /dev/nvme0n1p2, for example.

@jeaye jeaye merged commit f1a330b into jeaye:master Aug 29, 2016
@jeaye
Copy link
Owner

jeaye commented Aug 29, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants