-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UEFI support (rebased) #34
base: master
Are you sure you want to change the base?
Conversation
Conflicts: .gitignore install stage1
FYI I tried ./install -h on Ubuntu 14.04, and I am informed that fdisk doesn't have a -o option (pinging @Rotsor ) |
Oh whoops. I guess a couple of things can be done:
|
Thanks for the updated PR. I'd like to see this integrated with the existing test suite, which uses vagrant and various distros to ensure all is working well. The changes seem reasonable to me, minus some nitpicks. :) You up for testing this with vagrant? |
I agree with integrating it into tests! I did not author the original
PR myself, of course, and I do not think I will have time to do more
work for it. But perhaps the original author will? (Responding by
email and don't remember author's name — otherwise I'd @ them.)
…On Sat, Jun 10, 2017 at 04:31:05PM -0700, Jeaye Wilkerson wrote:
Thanks for the updated PR. I'd like to see this integrated with the existing test suite, which uses vagrant and various distros to ensure all is working well. The changes seem reasonable to me, minus some nitpicks. :)
You up for testing this with vagrant?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#34 (comment)
|
@Rotsor ^ |
I'll look into this. Hope I can make any heads or tails of vagrant. |
tails would be great man bless your heart
1C8TFFWbLbqSZ3YjGitoZE7cMdgpv2d4an
… On Jun 15, 2017, at 12:03 PM, Rotsor ***@***.***> wrote:
I'll look into this. Hope I can make any heads or tails of vagrant.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I tried this on AWS EC2 on an a1.large instance running ubuntu/images/hvm-ssd/ubuntu-bionic-18.04-arm64-server-20181121 (ami-00e744be929837e6e) and got this result:
|
I tested this PR, I had to hardcode the
These are the partitions on a Centos
I chose Btw ADDED: Nevermind this, I ditched this cloud provider and I'm going to use Hetzner, which has worked succesfully for me in the past. This info above may or may not be useful. |
This branch has the core commit of #32, cherry-picked on top of master, with conflicts resolved. Untested.
Conflicts:
.gitignore
install
stage1