Serialize the secret key to DER, not the public one

Fixes #74
jedisct1 · Oct 3, 2022 · d86040f · d86040f
1 parent 6b2ef16
commit d86040f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/algorithms/eddsa.rs b/src/algorithms/eddsa.rs
@@ -109,7 +109,7 @@ impl Edwards25519KeyPair {
     }
 
     pub fn to_der(&self) -> Vec<u8> {
-        self.ed25519_kp.pk.to_der()
+        self.ed25519_kp.sk.to_der()
     }
 
     pub fn to_pem(&self) -> String {

diff --git a/src/lib.rs b/src/lib.rs
@@ -498,6 +498,14 @@ a3t0cyDKinOY7JGIwh8DWAa4pfEzgg56yLcilYSSohXeaQV0nR8+rm9J8GUYXjPK
         assert!(claims.custom.is_custom);
     }
 
+    #[test]
+    fn ed25519_der() {
+        let key_pair = Ed25519KeyPair::generate();
+        let der = key_pair.to_der();
+        let key_pair2 = Ed25519KeyPair::from_der(&der).unwrap();
+        assert_eq!(key_pair.to_bytes(), key_pair2.to_bytes());
+    }
+
     #[test]
     fn require_nonce() {
         let key = HS256Key::generate();