forked from datacenter/ACI-Pre-Upgrade-Validation-Script
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #25 Fix #3
Open
jeestr4d
wants to merge
16
commits into
jeestr4d:Issue25
Choose a base branch
from
datacenter:Issue25
base: Issue25
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add l3out_overlapping_loopback_check * Add IPv6 handling in class IPAddress * ipv6_to_binary() as staticmethod --------- Co-authored-by: gmonroy <[email protected]>
…n as port description in lldp instead of dn (#123) * Added check for CSCwf00416 LLDP custom interface descriptions * Added error handling if no tversion is given * resolve review comments --------- Co-authored-by: gmonroy <[email protected]>
… empty or not explicitly matched (#128) * Adding check for route-map community match CSCwb08081 * Fixed formatting for get_switch_version. Now displays version and adds newline character. * rtmap_comm_match_defect_check now also checks for set statement in routemap. Fixed documentation.
* Issue #137: Added new check unsupported_fec_configuration_ex_check and updated validations.md * Added unit tests for unsupported_fec_configuration_ex_check and changed cversion to sw_cversion * Trimmed topSystem json for unit tests * Fixed empty data test case and removed redundant boolean vars
* invalid_fex_rs_check; check fex_ id >= 101 * review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.