Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 50xx NVIDIA Links to global stores #3210

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Mr-Tech-13
Copy link
Contributor

Added links to NVIDIA-gb, NVIDIA-FR, and NVIDIA-DE

@Mr-Tech-13 Mr-Tech-13 requested a review from jef as a code owner January 31, 2025 17:35
@GewoonJaap
Copy link
Contributor

Don't forget to run prettier ;)

@EbonyEquivocal
Copy link

I noticed you've changed the URL from https://shop.nvidia.com to https://marketplace.nvidia.com; how come? Does this matter?

Also, running your code, I get a lot of [nvidia-gb] nvidia 5080 founders edition - Navigation timeout of 30000 ms exceeded errors compared to before.

@Mr-Tech-13
Copy link
Contributor Author

It matters because store.nvidia.com no longer exists. Yes the timeout is normal. IDK Why it does it but the program is still 100% functional. It has something to do with the way Nvidia renders the site but if you run headless=false, you will see that the site is fully loaded the program just gets confused and hits the timeout.

@EbonyEquivocal
Copy link

It matters because store.nvidia.com no longer exists. Yes the timeout is normal. IDK Why it does it but the program is still 100% functional. It has something to do with the way Nvidia renders the site but if you run headless=false, you will see that the site is fully loaded the program just gets confused and hits the timeout.

Fair enough. Hopefully we can find a solution to the timeouts / errors.

@@ -4,12 +4,12 @@ export const NvidiaGB: Store = {
currency: '£',
labels: {
inStock: {
container: '.buy',
text: ['add to cart', 'buy now'],
container: 'span.buy-link-atc',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that the container ID for a founders being in stock is that same as it being in stock for a third party card? I'm raising this because the button looks different between founders and third party cards. When I checked the element for an out-of-stock FE card and an in stock third party card, they're different as well.

RTX 5080 FE in stock
image

Third party card in stock
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to fix it. I only designed it with fe cards in mind because as far as I could tell nvidia doesn't directly sell third party cards as far as I know. It's more efficient to track the third party

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm the same, I only want an FE card. The container ID you have works for third party cards but isn't the same for out of stock founders card from what I can see. It's annoying because the the founders card isn't in stock, we can't check what the ID is for the button.

@P-Adamiec
Copy link

Hello, I'm returning for my links too. Soo, as said, the official link for FE in my case is:
https://marketplace.nvidia.com/pl-pl/consumer/graphics-cards/nvidia-geforce-rtx-5090/
It is just as predicted. By replacing it to de-de I was able to investiage that the selectors have changed (If '.buy' means a class selector where there is this word in it - trying to learn some code. However, I'm not confident to do it alone. So please add the Polish store too, as I'm awaiting for 5090 FE release in Poland as we got 0 on paper launch...
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants