-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 50xx NVIDIA Links to global stores #3210
base: main
Are you sure you want to change the base?
Conversation
Update Selectors, add 5090/5080 FE
Don't forget to run prettier ;) |
I noticed you've changed the URL from https://shop.nvidia.com to https://marketplace.nvidia.com; how come? Does this matter? Also, running your code, I get a lot of |
It matters because store.nvidia.com no longer exists. Yes the timeout is normal. IDK Why it does it but the program is still 100% functional. It has something to do with the way Nvidia renders the site but if you run headless=false, you will see that the site is fully loaded the program just gets confused and hits the timeout. |
Fair enough. Hopefully we can find a solution to the timeouts / errors. |
@@ -4,12 +4,12 @@ export const NvidiaGB: Store = { | |||
currency: '£', | |||
labels: { | |||
inStock: { | |||
container: '.buy', | |||
text: ['add to cart', 'buy now'], | |||
container: 'span.buy-link-atc', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that the container ID for a founders being in stock is that same as it being in stock for a third party card? I'm raising this because the button looks different between founders and third party cards. When I checked the element for an out-of-stock FE card and an in stock third party card, they're different as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to fix it. I only designed it with fe cards in mind because as far as I could tell nvidia doesn't directly sell third party cards as far as I know. It's more efficient to track the third party
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm the same, I only want an FE card. The container ID you have works for third party cards but isn't the same for out of stock founders card from what I can see. It's annoying because the the founders card isn't in stock, we can't check what the ID is for the button.
Hello, I'm returning for my links too. Soo, as said, the official link for FE in my case is: |
Added links to NVIDIA-gb, NVIDIA-FR, and NVIDIA-DE